Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBP-247-transforming-terraform-modules-2 #2

Merged
merged 36 commits into from
Sep 14, 2023

Conversation

sahassou
Copy link
Contributor

@sahassou sahassou commented Sep 1, 2023

Description

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sahassou sahassou changed the title add infra-terraform-modules DBP-247-transforming-terraform-modules-2 Sep 1, 2023
@sahassou sahassou self-assigned this Sep 1, 2023
@sahassou
Copy link
Contributor Author

sahassou commented Sep 3, 2023

This code defines a GitHub Actions workflow that performs static code analysis on Terraform code using Checkov and TFLint.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@dimapin dimapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some files from a provider committed which should not be in the code. Please remove them

@aimee-889
Copy link
Contributor

https://github.com/dBildungsplattform/infra-terraform-modules/tree/aimee-gha-test/.github/workflows GHA actions for the time being should be used as they are configured in here. Further adjustments can be done in the future.

@sahassou sahassou merged commit a87e9aa into main Sep 14, 2023
@aimee-889 aimee-889 deleted the DBP-247-transforming-terraform-modules-2 branch September 14, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants