Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moodle hotfixes #75

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Moodle hotfixes #75

merged 5 commits into from
Nov 15, 2024

Conversation

JannikBadenhop
Copy link
Contributor

Description

  • fix config.php addtitional field by moving it to before the require_once line. it has no effect otherwise
  • split pgp.ini and config.php into a configmap and a secret respectively to allow for:
  • allow replacing the config.php with one from an existing Secret
  • create new secret for moodle-database values (except password), that is used by backup/restore. so that backup/restore can work properly with all possible databases

tested backup restore successfully 🥳
{07256D14-60E3-44B5-B7BB-48752280CD38}

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@JannikBadenhop JannikBadenhop requested review from marhode, maxi418 and a team November 14, 2024 16:31
@JannikBadenhop JannikBadenhop self-assigned this Nov 14, 2024
Copy link
Contributor

@marhode marhode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus

@JannikBadenhop JannikBadenhop merged commit 0ebf434 into main Nov 15, 2024
@JannikBadenhop JannikBadenhop deleted the dbp-000-hotfixes2 branch November 15, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants