Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for extraHosts with empty list and appropriate comment #68

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

JannikBadenhop
Copy link
Contributor

Description

The functionality for extra URLs is already there, just pretty hidden.
Refer to infra-03 NS for example

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@JannikBadenhop JannikBadenhop requested review from marhode, maxi418 and a team November 7, 2024 13:56
@JannikBadenhop JannikBadenhop self-assigned this Nov 7, 2024
@JannikBadenhop JannikBadenhop merged commit ae10807 into main Nov 11, 2024
@JannikBadenhop JannikBadenhop deleted the DBP-1049-moodle_w_2_urls branch November 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants