Added retention time value for helm chart #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bildungsplattform/dbp-moodle into OPS-7140-enable-backups-on-dev
maxi418
reviewed
Oct 25, 2024
charts/dbp-moodle/values.yaml
Outdated
| @@ -122,6 +122,8 @@ dbpMoodle: | |||
| # -- Backup configuration. Set enabled=true to enable the backup-cronjob. Also set s3 location credentials | |||
| backup: | |||
| enabled: false | |||
| retention_time: "" | |||
There was a problem hiding this comment.
Suggested change
| retention_time: "" | |
| # -- Defines the maximum age of a backup before it is deleted | |
| retention_time: "" |
There was a problem hiding this comment.
I like the comments. Can we also set a default value to demonstrate what values are expected? Like "1D".
This simply improves usability and has no impact on default chart creation, since backup is disabled by default
There was a problem hiding this comment.
Added comment and default Values. (The default values can also be found in the helpers.tpl)
maxi418
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the option to set a retention time for duply backups in the helm chart.
Links to Tickets or other PRs
Notes
Approval for review