Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPSH-1307 SchoolSH client and realm keys #86

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

SPSH-1307 SchoolSH client and realm keys #86

wants to merge 11 commits into from

Conversation

marode-cap
Copy link
Contributor

@marode-cap marode-cap commented Nov 25, 2024 •
edited
Loading

Description

  • Add new client for SchoolSH

    • Secret and signing/encryption certificate are loaded from secrets
    • rootUrl is configurable

  • Load realm-keys (rsa) from secrets

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@marode-cap marode-cap marked this pull request as ready for review November 25, 2024 13:33
@marode-cap marode-cap requested review from kristoff-kiefer and a team November 25, 2024 13:36
aimee-889
aimee-889 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@aimee-889 aimee-889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config and Secret Handling looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimee-889 aimee-889 aimee-889 approved these changes

@kristoff-kiefer kristoff-kiefer Awaiting requested review from kristoff-kiefer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marode-cap @aimee-889