-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use const/let instead of var #212
base: main
Are you sure you want to change the base?
Conversation
Using
I've tried collapsing vars (let x,y,z…) but terser is already doing it, and returns the same file. For the sake of science I tried to replace all (EDIT: when comparing the gzip'ed minified, we're talking of a difference of 20 bytes.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I love how it makes the code more clear in the sense that you know what can be expected to change with reassignment vs. not.
This change is great. Merging this PR would set a good precedent and open the door for future PRs that upgrade |
Do you still plan to merge this pull request now that d3 6 is out? |
* fix #234; exact log ticks * let/const (see also #212) Co-authored-by: Philippe Rivière <[email protected]>
Merge after #210
@curran