Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pooling.md - Fix typo in Chinese version #1309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YoHoSo
Copy link

@YoHoSo YoHoSo commented Nov 22, 2023

The index of X is not in accordance with the English version here (https://github.com/d2l-ai/d2l-en/blob/e4f0ed18d9d83cd35434404daaf7ffc9631b5ece/chapter_convolutional-neural-networks/pooling.md?plain=1#L117C1-L120C48)

English version uses X[i, j], X[i, j + 1],
X[i+1, j] and X[i+1, j + 1]

But Chinese version writes X[i, j], X[i, j + 1], X[i, j+1] and X[i, j + 2]

And the translation seems wrong a bit

The index of X is not in accordance with the English version here(https://github.com/d2l-ai/d2l-en/blob/e4f0ed18d9d83cd35434404daaf7ffc9631b5ece/chapter_convolutional-neural-networks/pooling.md?plain=1#L117C1-L120C48)

English version uses `X[i, j]`, `X[i, j + 1]`, 
`X[i+1, j]` and `X[i+1, j + 1]`

But Chinese version writes `X[i, j]`, `X[i, j + 1]`, 
`X[i, j+1]` and `X[i, j + 2]`

And the translation seems wrong a bit
Copy link

Job PR-1309-24bd135 is done.
Check the results at http://preview.d2l.ai/d2l-zh/PR-1309/24bd135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant