Compute exact p-values for small null configurations#114
Open
Compute exact p-values for small null configurations#114
Conversation
When the number of possible rankings C(total, num_pos) is less than or equal to null_size, compute exact null distribution by enumerating all combinations instead of random sampling. This provides exact p-values for small configurations like (5 replicates, 20 negcon) where C(20, 5) = 15,504 < 10,000. Closes #105 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
johnarevalo
requested changes
Dec 8, 2025
Member
|
Thanks for the PR!
Shouldn't this be C(25, 5)? 😄 |
Member
Author
Ah yes :) I've updated the example (and with a smaller one fwiw) |
Member
Author
|
@johnarevalo is this good to merge now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C(total, num_pos) <= null_size, compute exact null distribution by enumerating all possible rankings instead of random samplingexact_ap()function to enumerate all combinationsnull_dist_cached()to use exact computation when feasiblenull_sizefor consistent interfaceCloses #105
Example
For a small configuration with
num_pos=3positives andtotal=10items:C(10, 3) = 120If
null_size=10,000, all 120 exact AP scores are computed and tiled to fill 10,000 slots, giving exact p-values.Test plan
uv run pytestpasses (65 tests)uv run ruff check src/ tests/passesexact_ap, exact/random switching logic🤖 Generated with Claude Code