feat: Enable name
attribute as an independent selector config
#6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
name
attribute would only be utilized in a generated selector if a class-based option cannot be created. For UI Coverage several issues exist where we need to generate selectors around form fields and those can be identified in a more stable manner using thename
attribute in situations whereid
is not present.https://cypress-io.atlassian.net/browse/CYCLOUD-2174?focusedCommentId=30643
https://cypress-io.atlassian.net/browse/CYCLOUD-2111
I've chosen to break this out as a separate option in parallel with the existing
attributes
option - using that existing option would require elevatingattributes
aboveclass
and would have a much broader impact on the style & structure of generated selectors beyond the very targeted behavior change I'm looking for.Reviewer note: I think I don't have to do a
CSS.escape
on the attribute value here since it's inside quotes, but correct me if I'm wrong