-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply no-pause rule recursively #189
feat: apply no-pause rule recursively #189
Conversation
|
I would class your PR as a feature not a fix, since it extends the documented functionality, so the commit message would need to start with You would also need to sign the SLA before the Cypress.io team could consider your PR. |
e47aedd
to
eb900fc
Compare
@MikeMcC399 Thank you for your guidance. I was on the fence about which prefix to choose. |
The documentation has been reworked since you submitted this PR. Could you rebase your PR? Sorry for the inconvenience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts due to changes that have been done since this PR was submitted.
eb900fc
to
8696387
Compare
I rebased my PR and resolved all conflicts! |
Many thanks for your contribution! All looks good! Tested against npm install https://github.com/tom9744/eslint-plugin-cypress#user/tom9744/recursive-no-pause and additional test-spec /// <reference types="cypress" />
context('eslinting', () => {
it('pausing', () => {
cy.pause()
cy.visit('https://example.cypress.io').pause()
})
}) Add
(1) Note: rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good enhancement to the rule cypress/no-pause
!
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue
The
cypress/no-pause
rule only applies to a parent node.Changes
Convert the
isCypressCall
function into a recursive function to detect chained calls such ascy.get("...").pause();
.Closes #147