chore(deps): remove sharp dependency resolution #32378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
renovate
bot
force-pushed
the
renovate/npm-sharp-vulnerability
branch
from
afdac5f to
e9c4c52
Compare
jennifer-shehane
changed the title
|
Tracked down where this was introduced: edccfc9 sharp was a sub dependency of favicons, but I don't see that used anymore. I checked that the favicon is working after this change still. I don't think we need this resolution anymore. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
renovate/npm-sharp-vulnerability
|
| Run status |
|
| Run duration | 19m 26s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26661
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.11%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
157
|
Accessibility
97.71%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
110
|
jennifer-shehane
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.29.3->0.32.6GitHub Vulnerability Alerts
CVE-2022-29256
There's a possible vulnerability in logic that is run only at
npm installtime when installing versions ofsharpprior to the latest v0.30.5.This is not part of any runtime code, does not affect Windows users at all, and is unlikely to affect anyone that already cares about the security of their build environment. However, out of an abundance of caution, I've created this advisory.
If an attacker has the ability to set the value of the
PKG_CONFIG_PATHenvironment variable in a build environment then they might be able to use this to inject an arbitrary command atnpm installtime.I've used the Common Vulnerability Scoring System (CVSS) calculator to determine the maximum possible impact, which suggests a "medium" score of 5.9, but for most people the real impact will be dealing with the noise from automated security tooling that this advisory will bring.
AV:L/AC:L/PR:H/UI:R/S:U/C:H/I:H/A:H/E:P/RL:O/RC:C/CR:X/IR:X/AR:X/MAV:X/MAC:X/MPR:X/MUI:R/MS:X/MC:X/MI:X/MA:XThis problem was fixed in commit a6aeef6 and published as part of
sharpv0.30.5.Thank you very much to @dwisiswant0 for the responsible disclosure.
Remember: if an attacker has control over environment variables in your build environment then you have a bigger problem to deal with than this issue.
GHSA-54xq-cgqr-rpm3
Overview
sharp uses libwebp to decode WebP images and versions prior to the latest 0.32.6 are vulnerable to the high severity GHSA-j7hp-h8jx-5ppr.
Who does this affect?
Almost anyone processing untrusted input with versions of sharp prior to 0.32.6.
How to resolve this?
Using prebuilt binaries provided by sharp?
Most people rely on the prebuilt binaries provided by sharp.
Please upgrade sharp to the latest 0.32.6, which provides libwebp 1.3.2.
Using a globally-installed libvips?
Please ensure you are using the latest libwebp 1.3.2.
Possible workaround
Add the following to your code to prevent sharp from decoding WebP images.
Release Notes
lovell/sharp (sharp)
v0.32.6Compare Source
v0.32.5Compare Source
v0.32.4Compare Source
v0.32.3Compare Source
v0.32.2Compare Source
v0.32.1Compare Source
v0.32.0Compare Source
v0.31.3Compare Source
v0.31.2Compare Source
v0.31.1Compare Source
v0.31.0Compare Source
v0.30.7Compare Source
v0.30.6Compare Source
v0.30.5Compare Source
v0.30.4Compare Source
v0.30.3Compare Source
v0.30.2Compare Source
v0.30.1Compare Source
v0.30.0Compare Source
Configuration
📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.