fix: prevent navigating to about:blank #30864
Open
+5,847
−507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/about_blank_with_retry
|
| Run status |
|
| Run duration | 17m 42s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1090
|
Skipped
|
0
|
Passing
|
26423
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.56%
|
|
|---|---|
|
Untested elements
|
191
|
|
Tested elements
|
164
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
888
|
AtofStryker
approved these changes
Jan 13, 2025
|
|
||
| // there can only be one test in this file to ensure we are testing the scenario | ||
| // where a test fails and the runner does not navigate to about:blank between retries | ||
| it('test 1', () => { |
There was a problem hiding this comment.
can we give this a more descriptive name to what we are testing?
| if (test.failedFromHookId && (test.hookName === 'before all')) { | ||
| return null | ||
| } | ||
|
|
||
| // if this test hasn't been finalized, then we will be retry'ing it so just return this test |
There was a problem hiding this comment.
Suggested change
| // if this test hasn't been finalized, then we will be retry'ing it so just return this test | |
| // if this test hasn't been finalized, then we will be retrying it so just return this test |
cacieprins
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
If test isolation is disabled and the last test fails and then retries, we were incorrectly navigating to
about:blankdue to an incorrect calculation ofisLastTestThatWillRunInSuitethat was not accounting for retries. In order to resolve this issue, we are now accounting for retries by checkingtest.final.Steps to test
Run a spec in
runmode with test isolation off where the last test in the spec fails and then retries and verify we do not navigate toabout:blankin-between the retries.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?