Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cypress 14 as a peer dependency for webpack-dev-server #30862

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

AtofStryker
Copy link
Contributor

  • Closes

Additional details

To prevent users from using the newest @cypress/webpack-dev-server with older versions of Cypress, this PR sets cypress 14 and up as a peer dep for webpack dev server

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker self-assigned this Jan 10, 2025
Copy link

cypress bot commented Jan 10, 2025

cypress    Run #59837

Run Properties:  status check passed Passed #59837  •  git commit 68a1abefa6: fix: add cypress 14 as a peer dependency for webpack-dev-server
Project cypress
Branch Review fix/add_cypress_peer_dep_wds
Run status status check passed Passed #59837
Run duration 17m 36s
Commit git commit 68a1abefa6: fix: add cypress 14 as a peer dependency for webpack-dev-server
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 1090
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26418
View all changes introduced in this branch ↗︎
UI Coverage  45.68%
  Untested elements 190  
  Tested elements 164  
Accessibility  92.54%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 890  

@AtofStryker AtofStryker merged commit a46c2dd into develop Jan 13, 2025
90 of 91 checks passed
@AtofStryker AtofStryker deleted the fix/add_cypress_peer_dep_wds branch January 13, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants