Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: suppress more GPU related warnings #30861

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

d4v3y0rk
Copy link

@d4v3y0rk d4v3y0rk commented Jan 10, 2025

Closes Mesa/GLX related warnings shown when running Cypress #29521

Additional details

The primary Cypress process can emit benign warnings related to Mesa/GLX when running in certain Linux environments or containers. These warnings are related to graphics drivers and X11 display settings, but are not necessary for Cypress to execute correctly. This PR suppresses these warnings from stdout, similar to other benign Electron warnings:

  • error: XDG_RUNTIME_DIR is invalid or not set in the environment.
  • MESA: error: ZINK: failed to choose pdev
  • glx: failed to create drisw screen

Steps to test

  1. Execute Cypress tests in run mode on a Linux machine or container with minimal graphics drivers installed
  2. Execute Cypress tests in run mode in a Docker container using a basic Linux image (e.g. ubuntu:latest)
  3. Verify the suppressed warnings no longer appear in the terminal output

How has the user experience changed?

Users will no longer see benign graphics-related warnings in their terminal output when running Cypress in Linux environments with minimal graphics support. This reduces noise in the terminal output while not affecting any actual test functionality.

PR Tasks

  • Have tests been added/updated?
  • [NA] Has a PR for user-facing changes been opened in cypress-documentation?
  • [NA] Have API changes been updated in the type definitions?

Additional details

These errors are showing up when running under ubuntu 24.04

error: XDG_RUNTIME_DIR is invalid or not set in the environment.
MESA: error: ZINK: failed to choose pdev
glx: failed to create drisw screen

Steps to test

How has the user experience changed?

PR Tasks

Closes Mesa/GLX related warnings shown when running Cypress cypress-io#29521

### Additional details

The primary Cypress process can emit benign warnings related to Mesa/GLX when running in certain Linux environments or containers. These warnings are related to graphics drivers and X11 display settings, but are not necessary for Cypress to execute correctly. This PR suppresses these warnings from stdout, similar to other benign Electron warnings:

- `error: XDG_RUNTIME_DIR is invalid or not set in the environment.`
- `MESA: error: ZINK: failed to choose pdev`
- `glx: failed to create drisw screen`

### Steps to test

1. Execute Cypress tests in run mode on a Linux machine or container with minimal graphics drivers installed
2. Execute Cypress tests in run mode in a Docker container using a basic Linux image (e.g. ubuntu:latest)
3. Verify the suppressed warnings no longer appear in the terminal output

### How has the user experience changed?

Users will no longer see benign graphics-related warnings in their terminal output when running Cypress in Linux environments with minimal graphics support. This reduces noise in the terminal output while not affecting any actual test functionality.

### PR Tasks

- [x] Have tests been added/updated?
- [NA] Has a PR for user-facing changes been opened in cypress-documentation?
- [NA] Have API changes been updated in the type definitions?
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ d4v3y0rk
❌ Dave York


Dave York seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cypress-app-bot
Copy link
Collaborator

@d4v3y0rk d4v3y0rk marked this pull request as draft January 10, 2025 23:10
@d4v3y0rk d4v3y0rk marked this pull request as ready for review January 10, 2025 23:11
@MikeMcC399
Copy link
Contributor

@d4v3y0rk

@MikeMcC399

This comment was marked as resolved.

@d4v3y0rk
Copy link
Author

Done

@d4v3y0rk
Copy link
Author

Looks like I need to update the changelog too. I will do that when I get back to my computer.

@d4v3y0rk
Copy link
Author

@MikeMcC399 I am kindof at a loss as to what I am doing wrong in the changelog to pass the Semantic Pull Request Test.

cli/CHANGELOG.md Outdated Show resolved Hide resolved
@MikeMcC399
Copy link
Contributor

@d4v3y0rk

I am kindof at a loss as to what I am doing wrong in the changelog to pass the Semantic Pull Request Test.

The linting is quite demanding! I made a suggestion. See if it works!

Going with the suggesting.

Co-authored-by: Mike McCready <[email protected]>
@d4v3y0rk
Copy link
Author

@d4v3y0rk

I am kindof at a loss as to what I am doing wrong in the changelog to pass the Semantic Pull Request Test.

The linting is quite demanding! I made a suggestion. See if it works!

That did it.
Thanks!

@MikeMcC399
Copy link
Contributor

It looks like you have used your company e-mail in addition to the GitHub one, so CLA is asking you to sign for the other address as well.

If you don't want to have your company e-mail exposed, you'll probably want to replace that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants