-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add the packageManager
key generated by corepack to package.json
#30860
Conversation
packageManager
key to package.json
generated by corepackpackageManager
key generated by corepack to package.json
Are there any additional considerations for setting up a clone of Cypress due to this change? If yes, they should be added to CONTRIBUTING.md. You might want to mention: corepack enable yarn and the fact that |
corepack is marked with Stability: 1 - Experimental with the text "Use of the feature is not recommended in production environments."
|
@MikeMcC399 Thanks for the comments! This does not make corepack required, it just gives corepack some metadata about which package manager it should be selecting if it is enabled. |
cypress Run #59859
Run Properties:
|
Project |
cypress
|
Branch Review |
add-package-json-packageManager
|
Run status |
Passed #59859
|
Run duration | 18m 09s |
Commit |
73b6b546f0: Merge branch 'develop' into add-package-json-packageManager
|
Committer | Cacie Prins |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
6
|
Pending |
1090
|
Skipped |
0
|
Passing |
26419
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.68%
|
|
---|---|
Untested elements |
190
|
Tested elements |
164
|
Accessibility
92.55%
|
|
---|---|
Failed rules |
3 critical
8 serious
2 moderate
2 minor
|
Failed elements |
890
|
Additional details
When
yarn
is run viacorepack
, it adds thepackageManager
field topackage.json
if it isn't already present. This adds that field, referencing the latest version of Yarn Classic (1.22.22).Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?