Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the packageManager key generated by corepack to package.json #30860

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

When yarn is run via corepack, it adds the packageManager field to package.json if it isn't already present. This adds that field, referencing the latest version of Yarn Classic (1.22.22).

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins changed the title chore: add the packageManager key to package.json generated by corepack chore: add the packageManager key generated by corepack to package.json Jan 10, 2025
@cacieprins cacieprins marked this pull request as ready for review January 10, 2025 21:30
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jan 12, 2025

Are there any additional considerations for setting up a clone of Cypress due to this change?

If yes, they should be added to CONTRIBUTING.md.

You might want to mention:

corepack enable yarn

and the fact that corepack is experimental.

@MikeMcC399
Copy link
Contributor

corepack is marked with Stability: 1 - Experimental with the text "Use of the feature is not recommended in production environments."

@cacieprins
Copy link
Contributor Author

cacieprins commented Jan 13, 2025

@MikeMcC399 Thanks for the comments! This does not make corepack required, it just gives corepack some metadata about which package manager it should be selecting if it is enabled.

Copy link

cypress bot commented Jan 13, 2025

cypress    Run #59859

Run Properties:  status check passed Passed #59859  •  git commit 73b6b546f0: Merge branch 'develop' into add-package-json-packageManager
Project cypress
Branch Review add-package-json-packageManager
Run status status check passed Passed #59859
Run duration 18m 09s
Commit git commit 73b6b546f0: Merge branch 'develop' into add-package-json-packageManager
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 1090
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26419
View all changes introduced in this branch ↗︎
UI Coverage  45.68%
  Untested elements 190  
  Tested elements 164  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 890  

@cacieprins cacieprins merged commit 2f01310 into develop Jan 13, 2025
88 of 89 checks passed
@cacieprins cacieprins deleted the add-package-json-packageManager branch January 13, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants