Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove various dead code #30818

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+0 −23
Open

chore: remove various dead code #30818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b62842b
chore: remove various dead code
ryanthemanuel Jan 4, 2025
852c0e5
additional dead code
ryanthemanuel Jan 7, 2025
efba6df
Merge branch 'develop' into ryanm/chore/remove-dead-code
ryanthemanuel Jan 7, 2025
4435d4e
Merge branch 'develop' into ryanm/chore/remove-dead-code
jennifer-shehane Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/app/src/runner/event-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,6 @@ export class EventManager {
this._studioCopyToClipboard(cb)
})

this.localBus.on('studio:start', () => {
rerun()
})

this.localBus.on('studio:copy:to:clipboard', (cb) => {
this._studioCopyToClipboard(cb)
})
Expand Down
3 changes: 0 additions & 3 deletions packages/app/src/runner/iframe-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ export class IframeModel {
private highlightEl: ({ body }: any, opts: any) => void,
private isAUTSameOrigin: () => boolean,
private eventManager: EventManager,
private studio: {
selectorPlaygroundModel: any
},
) {
this._reset()
}
Expand Down
12 changes: 0 additions & 12 deletions packages/app/src/runner/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ function createIframeModel () {
autIframe.highlightEl,
autIframe.doesAUTMatchTopSuperDomainOrigin,
getEventManager(),
{
selectorPlaygroundModel: getEventManager().selectorPlaygroundModel,
},
)

iframeModel.listen()
Expand Down Expand Up @@ -185,8 +182,6 @@ function teardownSpec (isRerun: boolean = false) {
return getEventManager().teardown(getMobxRunnerStore(), isRerun)
}

let isTorndown = false

/**
* Called when navigating away from the runner page.
* This will teardown the reporter, event manager, and
Expand All @@ -198,7 +193,6 @@ export async function teardown () {
_eventManager?.teardown(getMobxRunnerStore())
await _eventManager?.resetReporter()
_eventManager = undefined
isTorndown = true
}

/**
Expand Down Expand Up @@ -353,14 +347,8 @@ async function runSpecE2E (config, spec: SpecFile) {
async function initialize () {
await dfd.promise

isTorndown = false

const config = getRunnerConfigFromWindow()

if (isTorndown) {
return
}

// Reset stores
const autStore = useAutStore()

Expand Down
4 changes: 0 additions & 4 deletions packages/app/src/store/studio-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,10 +896,6 @@ export const useStudioStore = defineStore('studioRecorder', {
return state.logs.length === 0
},

isReady (state): boolean {
return this.isOpen && this.isEmpty && !state.isLoading && !state.isFailed
},

hookId: (state) => {
return `${state.testId}-studio`
},
Expand Down
Loading