Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix system test firefox spawn message #30791

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 19, 2024

  • Closes n/a

Additional details

Updated the regex to account for the newline before the spawn message.

Steps to test

n/a

How has the user experience changed?

Before:

====================================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:    13.17.0                                                                            │
  │ Browser:    Firefox 133 (headless)                                                             │
  │ Specs:      1 found (issue_2196.cy.js)                                                         │
  │ Searched:   cypress/e2e/issue_2196.cy.js                                                       │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  issue_2196.cy.js                                                                (1 of 1)

Failed to spawn CDP with Firefox. Retrying...

Failed to spawn CDP with Firefox. Retrying again...


  issue #2196: overwriting visit
GET /index.html 200 2.604 ms - 92
GET /index.html 200 0.812 ms - 92
    ✓ fires onBeforeLoad (58ms)


  1 passing (947ms)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     0 seconds                                                                        │
  │ Spec Ran:     issue_2196.cy.js                                                                 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  issue_2196.cy.js                         945ms        1        1        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        945ms        1        1        -        -        -  

Different value of snapshot "e2e visit / low response timeout / calls onBeforeLoad when overwriting cy.visit"

----------
Difference
----------
                                                                                                     
   Running:  issue_2196.cy.js                                                                (1 of 1)
 
 
+
+
   issue #2196: overwriting visit
     ✓ fires onBeforeLoad
 

After:

====================================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:    13.17.0                                                                            │
  │ Browser:    Firefox 133 (headless)                                                             │
  │ Specs:      1 found (issue_2196.cy.js)                                                         │
  │ Searched:   cypress/e2e/issue_2196.cy.js                                                       │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  issue_2196.cy.js                                                                (1 of 1)

Failed to spawn CDP with Firefox. Retrying...

Failed to spawn CDP with Firefox. Retrying again...


  issue #2196: overwriting visit
GET /index.html 200 2.078 ms - 92
GET /index.html 200 0.699 ms - 92
    ✓ fires onBeforeLoad (56ms)


  1 passing (913ms)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     0 seconds                                                                        │
  │ Spec Ran:     issue_2196.cy.js                                                                 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  issue_2196.cy.js                         911ms        1        1        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        911ms        1        1        -        -        -  

      ✓ calls onBeforeLoad when overwriting cy.visit [firefox] (9268ms)


  1 passing (9s)

PR Tasks

Copy link

cypress bot commented Dec 19, 2024

cypress    Run #59218

Run Properties:  status check passed Passed #59218  •  git commit cfb67004fb: test: fix system test firefox spawn message
Project cypress
Branch Review mschile/firefox_system_test_fix
Run status status check passed Passed #59218
Run duration 18m 15s
Commit git commit cfb67004fb: test: fix system test firefox spawn message
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 73
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5591
View all changes introduced in this branch ↗︎

Warning

No Report: Something went wrong and we could not generate a report for the Application Quality products.

@mschile mschile merged commit 46744bb into develop Dec 19, 2024
89 of 90 checks passed
@mschile mschile deleted the mschile/firefox_system_test_fix branch December 19, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants