-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add type linting + compilation checks to packages #30776
Open
jennifer-shehane
wants to merge
19
commits into
develop
Choose a base branch
from
runner-check-ts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress Run #59230
Run Properties:
|
Project |
cypress
|
Branch Review |
runner-check-ts
|
Run status |
Failed #59230
|
Run duration | 21m 52s |
Commit |
717fa5280e: Merge branch 'develop' into runner-check-ts
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
7
|
Pending |
1326
|
Skipped |
0
|
Passing |
29398
|
View all changes introduced in this branch ↗︎ |
UI Coverage
46.11%
|
|
---|---|
Untested elements |
189
|
Tested elements |
166
|
Accessibility
92.51%
|
|
---|---|
Failed rules |
3 critical
8 serious
2 moderate
2 minor
|
Failed elements |
906
|
Tests for review
src/components/FileMatchIndicator.cy.tsx • 1 failed test • app-ct
Test | Artifacts | |
---|---|---|
An uncaught error was detected outside of a test |
Test Replay
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > automatically parses application/json request bodies |
Test Replay
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome
Test | Artifacts | |
---|---|---|
cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Test Replay
|
commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome
Test | Artifacts | |
---|---|---|
... > errors > throws when route is never resolved |
Test Replay
|
|
... > errors > throws when waiting for 2nd response to route |
Test Replay
|
commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit
Test | Artifacts | |||||||
---|---|---|---|---|---|---|---|---|
... > with `resourceType` > can match a proxied image request by resourceType |
commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit
|
jennifer-shehane
changed the title
chore: add type linting + compilation checks to runner package
chore: add type linting + compilation checks to packages
Dec 17, 2024
… into runner-check-ts
defaultMessages.specPage.banners.componentTesting.title = ctBannerTitle.replace('{0}', 'React') | ||
} | ||
|
||
cy.wrap(Object.entries(defaultMessages.specPage.banners[camelCase(bannerTestId)])).each((entry) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this assertion because after my updates, the rendering of the banner content was broken, but I only detected this through Percy. We should have a test that asserts on the content for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We aren't running typescript linting or compilation checks in many of our packages, so this is meant to remedy some of that. There were a lot of failures.
NOTE: This does not include running
tsc
on therunner
package since there were a lot more errors, but it is running tslint. See here: https://github.com/cypress-io/cypress/pull/30776/files#diff-3f56f0ca38e3b8dff3d2436a8f56f2cfb94120eeaa9af84182dce52d8a87d751R10Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?