Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add type linting + compilation checks to packages #30776

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 17, 2024

Additional details

We aren't running typescript linting or compilation checks in many of our packages, so this is meant to remedy some of that. There were a lot of failures.

NOTE: This does not include running tsc on the runner package since there were a lot more errors, but it is running tslint. See here: https://github.com/cypress-io/cypress/pull/30776/files#diff-3f56f0ca38e3b8dff3d2436a8f56f2cfb94120eeaa9af84182dce52d8a87d751R10

Steps to test

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Dec 17, 2024
Copy link

cypress bot commented Dec 17, 2024

cypress    Run #59230

Run Properties:  status check failed Failed #59230  •  git commit 717fa5280e: Merge branch 'develop' into runner-check-ts
Project cypress
Branch Review runner-check-ts
Run status status check failed Failed #59230
Run duration 21m 52s
Commit git commit 717fa5280e: Merge branch 'develop' into runner-check-ts
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29398
View all changes introduced in this branch ↗︎
UI Coverage  46.11%
  Untested elements 189  
  Tested elements 166  
Accessibility  92.51%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 906  

Tests for review

Failed  src/components/FileMatchIndicator.cy.tsx • 1 failed test • app-ct

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > automatically parses application/json request bodies Test Replay
Flakiness  e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin - cookie login > Max-Age > past max-age -> not logged in Test Replay
Flakiness  commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome

View Output

Test Artifacts
... > errors > throws when route is never resolved Test Replay
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
... > with `resourceType` > can match a proxied image request by resourceType
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/59230/overview/a92c2381-9069-443a-b9a9-50d5f53fb35d?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit

View Output

Test Artifacts
... > errors > throws waiting for the 3rd response
    </td>
  </tr></table>

@jennifer-shehane jennifer-shehane changed the title chore: add type linting + compilation checks to runner package chore: add type linting + compilation checks to packages Dec 17, 2024
defaultMessages.specPage.banners.componentTesting.title = ctBannerTitle.replace('{0}', 'React')
}

cy.wrap(Object.entries(defaultMessages.specPage.banners[camelCase(bannerTestId)])).each((entry) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this assertion because after my updates, the rendering of the banner content was broken, but I only detected this through Percy. We should have a test that asserts on the content for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant