Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: match newline in Firefox CDP spawn message #30753

Merged
merged 1 commit into from
Dec 12, 2024
Merged

test: match newline in Firefox CDP spawn message #30753

merged 1 commit into from
Dec 12, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 11, 2024

Additional details

The previous PR forgot to include the newline and global modifier in the regex so the system-tests were still failing.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

@mschile mschile self-assigned this Dec 11, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 11, 2024 •
edited
Loading

cypress    Run #58837

Run Properties:  status check passed Passed #58837  •  git commit 481e5ff75a: test: match newline in Firefox CDP spawn message
Project cypress
Branch Review mschile/firefox_newline
Run status status check passed Passed #58837
Run duration 11m 41s
Commit git commit 481e5ff75a: test: match newline in Firefox CDP spawn message
Committer Matthew Schile
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 669
View all changes introduced in this branch ↗︎
UI Coverage  38.03%
  Untested elements 132  
  Tested elements 81  
Accessibility  92.07%
  Failed rules  3 critical   7 serious   1 moderate   1 minor
  Failed elements 545  

@mschile mschile merged commit 499c361 into develop Dec 12, 2024
85 of 87 checks passed
@mschile mschile deleted the mschile/firefox_newline branch December 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees

@mschile mschile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CDP failed to spawn messaging from snapshot checks
3 participants
@mschile @jennifer-shehane @ryanthemanuel