Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove 'Alternatively you can use CommonJS syntax' comment from scaffolded component supportFile #30738

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 10, 2024

Additional details

Just saw this when reviewing CT issues to see if any could be closed for 14.

I figured I'd remove the comment from all our support files just to avoid future confusion on it.

Steps to test

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Dec 10, 2024
Copy link

cypress bot commented Dec 10, 2024

cypress    Run #58778

Run Properties:  status check passed Passed #58778  •  git commit dbcd7c40c6: changelog entry
Project cypress
Branch Review remove-commonjs-comment
Run status status check passed Passed #58778
Run duration 24m 55s
Commit git commit dbcd7c40c6: changelog entry
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29400
View all changes introduced in this branch ↗︎
UI Coverage  46.11%
  Untested elements 189  
  Tested elements 166  
Accessibility  92.54%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 902  

@jennifer-shehane jennifer-shehane merged commit 17639cb into develop Dec 11, 2024
85 of 86 checks passed
@jennifer-shehane jennifer-shehane deleted the remove-commonjs-comment branch December 11, 2024 16:03
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 17, 2024

Released in 13.17.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.17.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Alternatively you can use CommonJS syntax: require" from CT support file scaffold
3 participants