Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update userChrome.css to correctly hide the toolbox #30728

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: update userChrome.css to correctly hide the toolbox #30728

merged 2 commits into from
Dec 10, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 9, 2024

Additional details

Updated the userChrome.css to correctly hide the toolbox which also removed the need for the 722px workaround.

Steps to test

Tested with firefox 100, 130, and 133.

How has the user experience changed?

n/a

PR Tasks

@mschile mschile requested a review from AtofStryker December 9, 2024 16:18
@mschile mschile self-assigned this Dec 9, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 9, 2024 •
edited
Loading

cypress    Run #58757

Run Properties:  status check passed Passed #58757  •  git commit 7c817ea819: Merge branch 'develop' into mschile/firefox_userChrome
Project cypress
Branch Review mschile/firefox_userChrome
Run status status check passed Passed #58757
Run duration 16m 38s
Commit git commit 7c817ea819: Merge branch 'develop' into mschile/firefox_userChrome
Committer Matt Schile
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 949
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4679
View all changes introduced in this branch ↗︎

@mschile mschile merged commit dcd0e92 into develop Dec 10, 2024
84 of 85 checks passed
@mschile mschile deleted the mschile/firefox_userChrome branch December 10, 2024 14:38
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 17, 2024

Released in 13.17.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.17.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AtofStryker AtofStryker AtofStryker approved these changes

Assignees

@mschile mschile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

screenshot height dimensions changed in firefox 133
2 participants
@mschile @AtofStryker