Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for react 19 RC and make Nextjs 15.0.4 the minimum next supported #30723

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Dec 6, 2024

Additional details

React 19 Released yesterday. Previously, our plan was to support the React 19 RC until React 19 released. Since it released yesterday, we no longer need to support the RC with Cypress 14. Another side effect of this is we will only be officially supporting Next.js 15.0.4 for version 15 as version 15.0.0 - 15.0.3 rely on the React RC.

I am also logging this as a chore because the React RC change is not yet released, so the change is not breaking. The changelog for Next.js and React 19 are updated to reflect this change

Steps to test

Same as with The React 19 PR #30651 and the [Nextjs] PR #30654

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Dec 6, 2024

cypress    Run #58769

Run Properties:  status check passed Passed #58769  •  git commit b1bab21e99: Merge branch 'release/14.0.0' into chore/remove_support_react_19_rc_and_min_next...
Project cypress
Branch Review chore/remove_support_react_19_rc_and_min_next_15_0_4
Run status status check passed Passed #58769
Run duration 11m 26s
Commit git commit b1bab21e99: Merge branch 'release/14.0.0' into chore/remove_support_react_19_rc_and_min_next...
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 229
View all changes introduced in this branch ↗︎
UI Coverage  65.48%
  Untested elements 27  
  Tested elements 55  
Accessibility  96.23%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 196  

@AtofStryker AtofStryker marked this pull request as ready for review December 10, 2024 13:30
@AtofStryker AtofStryker merged commit c645017 into release/14.0.0 Dec 10, 2024
105 of 110 checks passed
@AtofStryker AtofStryker deleted the chore/remove_support_react_19_rc_and_min_next_15_0_4 branch December 10, 2024 15:49
@jennifer-shehane jennifer-shehane mentioned this pull request Dec 11, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress 14 Issues scoped for Cypress 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants