fix: failing Create Instance api call no longer skips spec #30697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/errors/src/errors.ts
Outdated
| @@ -188,6 +188,8 @@ export const AllCypressErrors = { | |||
|
|
|||
| ${fmt.highlightSecondary(arg1.response)} | |||
|
|
|||
| Because you passed the ${fmt.flag(`--record`)} flag, this run cannot proceed because it requires a valid response from our servers. | |||
There was a problem hiding this comment.
Just removing the double 'because'
Suggested change
| Because you passed the ${fmt.flag(`--record`)} flag, this run cannot proceed because it requires a valid response from our servers. | |
| Because you passed the ${fmt.flag(`--record`)} flag, this run cannot proceed since it requires a valid response from our servers. |
Co-authored-by: Jennifer Shehane <[email protected]>
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cacie/api-call-skips-spec
|
| Run status |
|
| Run duration | 22m 14s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29400
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
903
|
AtofStryker
approved these changes
Dec 3, 2024
| count = 0 | ||
| }) | ||
|
|
||
| it('errors and does not create or update instances when parallel', function () { |
There was a problem hiding this comment.
any reason we don't make these async/await tests to help with readability?
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/runs/<runId>/instancescall fails #30628Additional details
POSTing to create an instance is not idempotent.
In situations where the in-flight request is accepted by the Cloud API, but the client does not receive a response within the given timeout window, the retry attempt would create a new instance for the next spec, effectively bypassing specs.
Steps to test
The updated system tests now ensure this call is not retried; for manual testing, use Charles proxy or similar to cause a timeout on the POST runs/:id/instances request.
How has the user experience changed?
Runs will fail if the client fails to register the creation of an instance when either the
--recordor--parallelflag is passed. This prevents potential false negatives, where a spec skipped due to this would have failed and thus reported a test failure.PR Tasks
cypress-documentation?type definitions?