misc: remove component testing API stubs that were removed in Cypress 11 #30696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
changed the title
jennifer-shehane
approved these changes
Dec 2, 2024
AtofStryker
approved these changes
Dec 2, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/remove_ct_11_code
|
| Run status |
|
| Run duration | 17m 52s |
| Commit |
|
| Committer | Matt Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29379
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.07%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
164
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
891
|
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress/react#30623Additional details
With Cypress 11, we made breaking changes to the component testing API but left in some stubs that threw errors if they were accessed. Since this will be the 3rd major release since those breaking changes, we are removing the code that was throwing those errors.
Steps to test
n/a
How has the user experience changed?
Errors are no longer thrown.
PR Tasks
cypress-documentation?type definitions?