Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- #30604

Closed
wants to merge 30 commits into from
Closed

- #30604

wants to merge 30 commits into from

Conversation

alexsch01
Copy link
Contributor

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

alexsch01 and others added 30 commits November 1, 2024 14:12
@alexsch01
feat: ability to specify the default browser in cypress config file
44e0c99
@alexsch01
don't need setActiveBrowserByNameOrPath for run mode
24e3dda
@alexsch01
restore readonly on attribute
f8789ab
@alexsch01
simplify cypress open version
2f82876
@alexsch01
put isBrowserGivenByCli on modeOptions (#4)
11bd244 
* Update coreDataShape.ts

* Update ProjectLifecycleManager.ts
@alexsch01
Update cypress.d.ts
c1fc1b2
@alexsch01
use isBrowserGivenByCli only for run mode (#5)
66d26b1 
* Update modeOptions.ts

* Update index.ts

* Update ProjectLifecycleManager.ts
@alexsch01
make defaultBrowser more conformant
d4a68ba
@alexsch01
Update CHANGELOG.md
8028e51
@alexsch01
Update CHANGELOG.md
77ffd7a
@alexsch01
Update CHANGELOG.md
5d6202d
@jennifer-shehane
Merge branch 'develop' into defaultBrowser-config
17c40b3
@alexsch01
oops (#6)
d036d96 
* oops

* oops
@jennifer-shehane
Merge branch 'develop' into defaultBrowser-config
08fb3a3
@alexsch01
changes (#7)
7aaf2a9
@alexsch01
more test fixes (#8)
b7cb459 
* make test run with all versions of system-tests

* Update index.spec.ts.js

* Update index.spec.ts.js

* Update utils.spec.ts

* Update results_spec.ts.js
@alexsch01
Update utils.spec.ts
ea67832
@alexsch01 @mschile
Update packages/config/src/options.ts
4f1cd4d 
Co-authored-by: Matt Schile <[email protected]>
@alexsch01 @mschile
Update cli/CHANGELOG.md
7154055 
Co-authored-by: Matt Schile <[email protected]>
@alexsch01 @mschile
Update cli/types/cypress.d.ts
9a740c4 
Co-authored-by: Matt Schile <[email protected]>
@alexsch01 @mschile
Update packages/config/src/options.ts
2dddf0f 
Co-authored-by: Matt Schile <[email protected]>
@alexsch01 @mschile
Update packages/data-context/src/data/ProjectLifecycleManager.ts
5f1d6b9 
Co-authored-by: Matt Schile <[email protected]>
@alexsch01
Update DataContext.ts
adec731
@alexsch01
Update DataContext.ts
4425433
@alexsch01
final oops
6933638
@alexsch01
remove requireRestartOnChange for defaultBrowser, prevent bad open mo…
2a53ba0 
…de behavior (#9)

* Update options.ts

* Update DataContext.ts
@alexsch01
oops
fd9c123
@alexsch01
Update DataContext.ts
c5ace21
@alexsch01
Update BrowserActions.ts
568d222
@alexsch01
Update ProjectLifecycleManager.ts
c6766bc
@alexsch01 alexsch01 closed this Nov 12, 2024
@alexsch01 alexsch01 changed the title hope this still works - Nov 12, 2024
@cypress-app-bot
Copy link
Collaborator

@alexsch01 alexsch01 deleted the defaultBrowser-config2 branch November 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann Awaiting requested review from brian-mann brian-mann is a code owner

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane jennifer-shehane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsch01 @cypress-app-bot @jennifer-shehane