Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove Svelte 3 support #30572

Merged
merged 11 commits into from
Nov 9, 2024
Merged

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Nov 7, 2024

Additional details

Removes support for Svelte version 3.

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Nov 7, 2024

cypress    Run #58308

Run Properties:  status check passed Passed #58308  •  git commit 60dd249932: pr updates
Project cypress
Branch Review mschile/svelte_3_removal
Run status status check passed Passed #58308
Run duration 17m 44s
Commit git commit 60dd249932: pr updates
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 1327
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29321
View all changes introduced in this branch ↗︎
UI Coverage  46.26%
  Untested elements 189  
  Tested elements 167  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 893  

@AtofStryker AtofStryker self-requested a review November 8, 2024 15:42
cli/CHANGELOG.md Outdated Show resolved Hide resolved
npm/svelte/rollup.config.mjs Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@AtofStryker AtofStryker linked an issue Nov 8, 2024 that may be closed by this pull request
@AtofStryker
Copy link
Contributor

can you link the docs PR as well once it's ready for review?

@mschile
Copy link
Contributor Author

mschile commented Nov 8, 2024

can you link the docs PR as well once it's ready for review?

cypress-io/cypress-documentation#5999

@mschile mschile merged commit 249da65 into release/14.0.0 Nov 9, 2024
80 of 82 checks passed
@mschile mschile deleted the mschile/svelte_3_removal branch November 9, 2024 05:10
@jennifer-shehane jennifer-shehane mentioned this pull request Dec 3, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaking: remove Svelte@3 support
3 participants