breaking: remove support for Angular <17.2.0 for Cypress Component Testing #30539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
added
npm: @cypress/angular
AtofStryker
force-pushed
the
breaking/remove_angular_under_17_2
branch
from
675b156 to
47ea457
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_angular_under_17_2
|
| Run status |
|
| Run duration | 17m 29s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
1327
|
Skipped
|
0
|
Passing
|
29317
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.67%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
168
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
893
|
AtofStryker
force-pushed
the
breaking/remove_angular_under_17_2
branch
8 times, most recently
from
abd9411 to
a6c2708
Compare
AtofStryker
commented
Nov 5, 2024
| @@ -7,29 +7,28 @@ | |||
| "build": "tsc -p tsconfig.json", | |||
| "build:watch": "tsc -p tsconfig.json --watch", | |||
| "lint": "eslint --ext .ts,.json, .", | |||
| "test": "mocha -r @packages/ts/register --reporter mocha-multi-reporters --reporter-options configFile=../../mocha-reporter-config.json src/**/*.spec.ts" | |||
| "test": "vitest run --no-file-parallelism" | |||
There was a problem hiding this comment.
I updated cypress-schematic to use vitest as the mocking library is much easier to use and it can run ts files natively. I wound up not needing the mocking but still think this a good addition
AtofStryker
commented
Nov 5, 2024
| }) | ||
|
|
||
| it('should create cypress component tests alongside components', async () => { | ||
| return schematicRunner.runSchematicAsync('specs-ct', { project: 'sandbox' }, appTree).pipe(take(1)).subscribe((tree: UnitTestTree) => expect(tree.files).to.contain('/projects/sandbox/app/src/app.component.cy.ts')) | ||
| const tree = await schematicRunner.runSchematic('specs-ct', { project: 'sandbox' }, appTree) |
There was a problem hiding this comment.
this test was previously passing when it shouldn't have. I cannot mock the file system easily, so I added a projects/sandbox/src with a .gitkeep to make this test mock generate the cypress test correctly.
mschile
reviewed
Nov 6, 2024
mschile
approved these changes
Nov 6, 2024
…n is now 17.2.0 breaking: cypress-schematic only supports angular 17.2.0 and up [run ci] fix updates missed [run ci]
AtofStryker
force-pushed
the
breaking/remove_angular_under_17_2
branch
from
a6c2708 to
74f853b
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Removes CT support for angular versions under
17.2.0. This is needed in order to merge theangular-signalstest harness into the main test harness #29606. This also updates thecypress-schematicto have a peer dependency on angular17.2.0and up and updates the tests to use the latest devkit and leveragesvitestin band instead of mocha/chaiSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation? chore: update angular documentation with supported versions from Cypress 14 cypress-documentation#5983type definitions?