fix: ensure we have marked things as stable prior to after/afterEach hooks running #30536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
commented
Nov 4, 2024
ryanthemanuel
changed the title
mschile
reviewed
Nov 4, 2024
mschile
approved these changes
Nov 4, 2024
Co-authored-by: Matt Schile <[email protected]>
jennifer-shehane
approved these changes
Nov 4, 2024
AtofStryker
approved these changes
Nov 4, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/fix/issue-with-stability
|
| Run status |
|
| Run duration | 23m 51s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29400
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.24%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
906
|
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When we have a
pageLoadTimeout, the Cypress runner can be left in an unstable state. Cypress waits to execute further commands until we are in a stable state. As a result, if we haveafter/afterEachhooks that run after the failure, they have the potential to hang indefinitely. This PR fixes the issue by ensuring that we have stability prior to moving to theafter/afterEachhooks.Steps to test
I added a driver test for this.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?