Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run renovate with yarn deduplication highest strategy #30060

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Aug 19, 2024

Additional details

Renovate is not deduping deps like our commits do locally and it's causing a lot of conflicts where we have to later update the yarn.lock. Renovate has this option that I think will resolve this discrepancy.

Steps to test

I guess we'll have to see on the next renovate PR.

How has the user experience changed?

N/A

PR Tasks

Copy link

cypress bot commented Aug 19, 2024

cypress    Run #56642

Run Properties:  status check passed Passed #56642  •  git commit 5e8df1dd73: empty commit
Project cypress
Branch Review renovate-yarn-deduper-highest-option
Run status status check passed Passed #56642
Run duration 51m 30s
Commit git commit 5e8df1dd73: empty commit
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 9
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 667
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 5  
  Tested elements 0  
Accessibility  97.4%
  Failed rules  0 critical   1 serious   0 moderate   0 minor
  Failed elements 6  

@jennifer-shehane jennifer-shehane merged commit f666aec into develop Aug 19, 2024
83 of 84 checks passed
@jennifer-shehane jennifer-shehane deleted the renovate-yarn-deduper-highest-option branch August 19, 2024 20:58
AtofStryker pushed a commit that referenced this pull request Aug 21, 2024
* empty commit

* Update renovate.json to run yarn deduplication with highest strategy

* empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renovate PRs may include yarn.lock with mismatched lockfile
3 participants