fix: Upgrade elliptic to address security vulnerability #30037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
approved these changes
Aug 14, 2024
| @@ -44,7 +44,7 @@ module.exports = (on) => { | |||
| } | |||
| ``` | |||
|
|
|||
| Other than the `typescript` option, this preprocessor supports the same options as [@cypress/webpack-preprocessor](https://github.com/cypress-io/cypress/tree/develop/npm/webpack-preprocessor#readme), so see its README for more information. | |||
There was a problem hiding this comment.
Just a file change to trigger the release in this package which is triggered by any file update in this package directory. This change is unrelated.
AtofStryker
approved these changes
Aug 14, 2024
|
Snyk check is passing now. |
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix-elliptic-vulnerability
|
| Run status |
|
| Run duration | 24m 17s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1328
|
Skipped
|
0
|
Passing
|
29312
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
43.4%
|
|
|---|---|
|
Untested elements
|
218
|
|
Tested elements
|
171
|
Accessibility
91.26%
|
|
|---|---|
|
Failed rules
|
5 critical
10 serious
2 moderate
2 minor
|
|
Failed elements
|
945
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This addresses a critical vulnerability that was surfaced here: https://security.snyk.io/vuln/SNYK-JS-ELLIPTIC-7577916
This was in our
@cypress/webpack-batteries-included-preprocessorpackage as a sub dependency of another dependency. Issue opened for that package here: browserify/crypto-browserify#234Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?