Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add external contributor PR advice #29919

Merged

Conversation

MikeMcC399
Copy link
Contributor

Additional details

The CONTRIBUTING > Pull Requests documentation section did not describe how an external contributor should respond to GitHub PR status messages caused by the base branch (usually develop) moving on, causing out-of-date or conflict messages.

This documentation gap is now closed with additional text.

Steps to test

N/A documentation change only.

How has the user experience changed?

Contributor process clarification only. No end-user experience change.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Please feel to modify any of the text if I got it wrong! 🙂

@MikeMcC399
Copy link
Contributor Author

Haha - Proof of Concept! This PR is now in out-of-date status! Since the CI run has not hit the approval gate, I'm going to update it with the "Update branch" button.

@MikeMcC399
Copy link
Contributor Author

... and again for the same reason

@MikeMcC399
Copy link
Contributor Author

Update branch once more. Status is currently showing
2 skipped, 28 successful, 28 expected, 1 in progress, and 1 pending checks

@jennifer-shehane
Copy link
Member

@MikeMcC399 Yah I don't typically run the tests for docs changes. It's pretty heavy handed.

@jennifer-shehane jennifer-shehane merged commit bbdb10b into cypress-io:develop Jul 26, 2024
29 of 32 checks passed
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Yah I don't typically run the tests for docs changes. It's pretty heavy handed.

Thanks for that feedback! I was more going through the process to see if I could sensibly follow the rules I had written up. They don't cover every eventuality, but I think they are helpful as guidance.

@MikeMcC399 MikeMcC399 deleted the issue-29671-contributing-pr branch July 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend CONTRIBUTING for actions after PR submission
4 participants