-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add external contributor PR advice #29919
docs: add external contributor PR advice #29919
Conversation
|
Please feel to modify any of the text if I got it wrong! 🙂 |
Haha - Proof of Concept! This PR is now in out-of-date status! Since the CI run has not hit the approval gate, I'm going to update it with the "Update branch" button. |
... and again for the same reason |
Update branch once more. Status is currently showing |
@MikeMcC399 Yah I don't typically run the tests for docs changes. It's pretty heavy handed. |
Thanks for that feedback! I was more going through the process to see if I could sensibly follow the rules I had written up. They don't cover every eventuality, but I think they are helpful as guidance. |
Additional details
The CONTRIBUTING > Pull Requests documentation section did not describe how an external contributor should respond to GitHub PR status messages caused by the base branch (usually
develop
) moving on, causing out-of-date or conflict messages.This documentation gap is now closed with additional text.
Steps to test
N/A documentation change only.
How has the user experience changed?
Contributor process clarification only. No end-user experience change.
PR Tasks
cypress-documentation
?type definitions
?