Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 29752 and 25554 baseUrl slash breaks URL when trying to append query string #29759

Conversation

malikabakhtiyorova
Copy link

@malikabakhtiyorova malikabakhtiyorova commented Jun 27, 2024

Additional details

  • Issue: The baseUrl feature is appending a slash to the baseUrl, which can cause some websites to disconnect or fail to fire their load event.
  • Fix: Checking if the pathUrl is actually a querystring, if so don't append the slash

Steps to test

as described in 29752 and 25554.

How has the user experience changed?

if:

baseUrl: "https:/example.com"

and used with query parameters like this:

cy.visit('?id=1')

previous behavior:
it visits: https:/example.com/?id=1 (with additional slash)

current behavior with the changes:
it visits: https:/example.com?id=1 (without slash for querystrings)

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need tests to cover this fix.

@jennifer-shehane
Copy link
Member

@malikabakhtiyorova Can you provide tests to verify this change? Otherwise we'll have to close the PR.

@jennifer-shehane
Copy link
Member

Closing since there's been no response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants