Cacie/chore/upgrade electron 27

.circleci/workflows.yml

@@ -29,7 +29,8 @@ mainBuildFilters: &mainBuildFilters
         - develop
         - /^release\/\d+\.\d+\.\d+$/
         # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
-        - 'update-v8-snapshot-cache-on-develop'
+        - 'cacie/chore/upgrade-electron-27'
+
 
 # usually we don't build Mac app - it takes a long time
 # but sometimes we want to really confirm we are doing the right thing
@@ -40,7 +41,7 @@ macWorkflowFilters: &darwin-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'mschile/protocol/proxy_correlation', << pipeline.git.branch >> ]
+    - equal: [ 'cacie/chore/upgrade-electron-27', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -51,7 +52,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'mschile/protocol/proxy_correlation', << pipeline.git.branch >> ]
+    - equal: [ 'cacie/chore/upgrade-electron-27', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -74,7 +75,7 @@ windowsWorkflowFilters: &windows-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'mschile/protocol/proxy_correlation', << pipeline.git.branch >> ]
+    - equal: [ 'cacie/chore/upgrade-electron-27', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -83,7 +84,7 @@ executors:
   # the Docker image with Cypress dependencies and Chrome browser
   cy-doc:
     docker:
-      - image: cypress/browsers-internal:node18.15.0-chrome114-ff115
+      - image: cypress/browsers-internal:node18.17.0-chrome118-ff115
     # by default, we use "medium" to balance performance + CI costs. bump or reduce on a per-job basis if needed.
     resource_class: medium
     environment:
@@ -93,7 +94,7 @@ executors:
   # Docker image with non-root "node" user
   non-root-docker-user:
     docker:
-      - image: cypress/browsers-internal:node18.15.0-chrome114-ff115
+      - image: cypress/browsers-internal:node18.17.0-chrome118-ff115
         user: node
     environment:
       PLATFORM: linux
@@ -546,7 +547,7 @@ commands:
             if [[ ! -f better_sqlite3.node ]]; then
               docker run -d --name centos7-builder centos7-builder /bin/bash -c "sleep 1000000000"
               docker cp ~/cypress/node_modules/better-sqlite3 centos7-builder:/better-sqlite3
-              docker exec -it centos7-builder /bin/bash -c "cd /better-sqlite3 && source /root/.bashrc && chown -R root:root . && npm install --ignore-scripts && npx --no-install prebuild -r electron -t 25.0.0 --include-regex 'better_sqlite3.node$'"
+              docker exec -it centos7-builder /bin/bash -c "cd /better-sqlite3 && source /root/.bashrc && chown -R root:root . && npm install --ignore-scripts && npx --no-install prebuild -r electron -t 27.1.3 --include-regex 'better_sqlite3.node$'"
               docker cp centos7-builder:/better-sqlite3/build/Release/better_sqlite3.node ~/cypress/node_modules/better-sqlite3/build/Release/better_sqlite3.node
               docker rm -f centos7-builder
               cp ~/cypress/node_modules/better-sqlite3/build/Release/better_sqlite3.node ~/cypress/better_sqlite3.node
@@ -1219,6 +1220,12 @@ commands:
             else
               yarn binary-package --version $(node ./scripts/get-next-version.js)
             fi
+      - run:
+          name: Smoke Test the Cypress binary
+          command: |
+            source ./scripts/ensure-node.sh
+            node --version
+            yarn binary-smoke-test --version $(node ./scripts/get-next-version.js)
       - run:
           name: Zip the binary
           command: |
@@ -2319,7 +2326,7 @@ jobs:
     <<: *defaults
     resource_class: small
     docker:
-      - image: cypress/base-internal:18.15.0
+      - image: cypress/base-internal:18.17.0
     steps:
       - maybe_skip_binary_jobs
       - restore_workspace_binaries

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -43,7 +43,7 @@ body:
     attributes:
       label: Node version
       description: What version of node.js are you using to run Cypress?
-      placeholder: ex. v18.15.0
+      placeholder: ex. v18.17.0
     validations:
       required: true
   - type: input

.github/ISSUE_TEMPLATE/2-memory-issue.yml

@@ -51,7 +51,7 @@ body:
     attributes:
       label: Node version
       description: What version of node.js are you using to run Cypress?
-      placeholder: ex. v18.15.0
+      placeholder: ex. v18.17.0
     validations:
       required: true
   - type: input

.github/ISSUE_TEMPLATE/3-install-issue.yml

@@ -38,7 +38,7 @@ body:
     attributes:
       label: Node version
       description: What version of node.js are you using to run Cypress?
-      placeholder: ex. v18.15.0
+      placeholder: ex. v18.17.0
     validations:
       required: true
   - type: dropdown

.github/workflows/update_v8_snapshot_cache.yml

@@ -48,6 +48,9 @@ jobs:
       - name: Determine snapshot files - Mac
         if: ${{ matrix.platform == 'macos-latest' }}
         run: echo "SNAPSHOT_FILES='tooling/v8-snapshot/cache/darwin/snapshot-meta.json'" >> $GITHUB_ENV
+      - name: Install setuptools - Mac
+        if: ${{ matrix.platform == 'macos-latest' }}
+        run: sudo -H pip install setuptools
       - name: Checkout
         uses: actions/checkout@v3
         with:

.node-version

@@ -1 +1 @@
-18.15.0
+18.17.1

centos7-builder.Dockerfile

@@ -1,5 +1,5 @@
 FROM centos:7
-# Install dependencies for re-building better-sqlite and setting devtoolset-8 as the default compiler
+# Install dependencies for re-building better-sqlite and setting devtoolset-8 as the default compiler.
 RUN yum -y install centos-release-scl curl python3 make atk-devel atk java-atk-wrapper at-spi2-atk gtk3 libXt libdrm mesa-libgbm Xvfb && yum -y install devtoolset-8-gcc devtoolset-8-gcc-c++
 RUN echo >> /etc/profile.d/devtoolset-8.sh 'source scl_source enable devtoolset-8'
 RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.5/install.sh | bash

cli/CHANGELOG.md

@@ -1,6 +1,15 @@
 <!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
 ## 13.6.4
 
+_Released 1/30/2024 (PENDING)_
+
+** Dependency Updates:**
+
+- Updated  `@cypress/unique-selector` to include a performance optimization. It's possible this could improve performance of the selector playground. Addressed in [#28571](https://github.com/cypress-io/cypress/pull/28571).
+- Upgraded `electron` from `25.8.4` to `27.1.3`
+- Upgraded bundled Node.js version from `18.15.0` to `18.17.0`
+- Upgraded bundled Chromium version from `114.0.5735.289` to `116.0.5845.228`
+
 **Performance:**
 
 - Fixed a performance regression from [`13.3.2`](https://docs.cypress.io/guides/references/changelog#13.3.2) where aborted requests may not correlate correctly. Fixes [#28734](https://github.com/cypress-io/cypress/issues/28734).
@@ -40,6 +49,7 @@ _Released 1/16/2024_
 - Improved accessibility of some areas of the Cypress App. Addressed in [#28628](https://github.com/cypress-io/cypress/pull/28628).
 - Updated some documentation links to go through on.cypress.io. Addressed in [#28623](https://github.com/cypress-io/cypress/pull/28623).
 
+
 ## 13.6.2
 
 _Released 12/26/2023_

docker-compose.yml

@@ -33,7 +33,7 @@ services:
       - .:/opt/cypress
   ci:
     # This should mirror the image used in workflows.yml
-    image: cypress/browsers-internal:node18.15.0-chrome114-ff115
+    image: cypress/browsers-internal:node18.17.0-chrome118-ff115
     ports:
       - 5566:5566
       - 5567:5567

guides/building-release-artifacts.md

@@ -38,3 +38,9 @@ You can build the Cypress binary locally by running `yarn binary-build`, then pa
 If you're on macOS and building locally, you'll need a code-signing certificate in your keychain, which you can get by following the [instructions on Apple's website](https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html#//apple_ref/doc/uid/TP40005929-CH4-SW30). Also, you'll also most likely want to skip notarization since it requires an Apple Developer Program account - set `SKIP_NOTARIZATION=1` when building locally to do this. [More info about code signing in CI](./code-signing.md).
 
 `yarn binary-zip` can be used to zip the built binary together.
+
+### Tips
+
+If you want to speed up the time it takes to package the binary, set `V8_SNAPSHOT_DISABLE_MINIFY=1`
+
+If you are on an M1, you need to set `RESET_ADHOC_SIGNATURE=1` in order to be able to actually run the binary after packaging it.

package.json

@@ -10,6 +10,7 @@
     "binary-ensure": "node ./scripts/binary.js ensure",
     "binary-purge": "node ./scripts/binary.js purge-version",
     "binary-release": "node ./scripts/binary.js release",
+    "binary-smoke-test": "node ./scripts/binary.js smoke",
     "binary-upload": "node ./scripts/binary.js upload",
     "binary-zip": "node ./scripts/binary.js zip",
     "binary-package": "cross-env NODE_OPTIONS=--max_old_space_size=8192 node ./scripts/binary.js package",
@@ -145,7 +146,7 @@
     "dedent": "^0.7.0",
     "del": "3.0.0",
     "detect-port": "^1.3.0",
-    "electron": "25.8.4",
+    "electron": "27.1.3",
     "electron-builder": "^23.6.0",
     "enzyme-adapter-react-16": "1.12.1",
     "eslint": "7.22.0",
@@ -211,7 +212,7 @@
     "yarn-deduplicate": "3.1.0"
   },
   "engines": {
-    "node": ">=18.15.0",
+    "node": ">=18.17.0",
     "yarn": ">=1.17.3"
   },
   "productName": "Cypress",

packages/app/cypress/component/support/index.ts

@@ -48,5 +48,5 @@ registerMountFn({ plugins: [() => createRouter(), () => pinia] })
 
 installCustomPercyCommand()
 
-Cypress.on('uncaught:exception', (err) => !err.message.includes('ResizeObserver loop limit exceeded'))
+Cypress.on('uncaught:exception', (err) => !err.message.includes('ResizeObserver loop completed with undelivered notifications.'))
 Cypress.Commands.add('tabUntil', tabUntil)

packages/app/src/components/Slideshow.vue

@@ -2,7 +2,7 @@
   <div class="relative">
     <!-- leave-to classes are marked absolute to allow the entering component to
     animate on top of the leaving component, creating a fading animation with no thrashing -->
-    <transition
+    <transition-group
       enter-from-class="opacity-0"
       enter-active-class="transition duration-300 ease-out"
       enter-to-class="opacity-100"
@@ -18,7 +18,7 @@
         :go-forward="increment"
         :reset="reset"
       />
-    </transition>
+    </transition-group>
   </div>
 </template>
 

packages/app/src/debug/empty/DebugEmptyStates.cy.tsx

@@ -66,8 +66,7 @@ describe('Debug page empty states', { defaultCommandTimeout: 250 }, () => {
 
           // ensure the promos are done transitioning before clicking on the control
           // since 2 buttons could display if both promos are easing in and out
-          cy.findByTestId('promo-action')
-          .should('not.have.class', 'ease-in')
+          cy.findAllByTestId('guide-card', { timeout: 350 }).should('not.have.class', 'ease-in')
           .and('not.have.class', 'ease-out')
 
           cy.findByTestId('promo-action-control').click()

packages/app/src/debug/guide/DebugGuide.vue

@@ -20,14 +20,17 @@
       <GuideCard1
         v-if="step === 0"
         :action="goForward"
+        data-cy="guide-card"
       />
       <GuideCard2
         v-else-if="step === 1"
         :action="goForward"
+        data-cy="guide-card"
       />
       <GuideCard3
         v-else-if="step === 2"
         :action="reset"
+        data-cy="guide-card"
       />
     </template>
   </Promo>