fix: Remove erroneous <br> tags from error messages

[jennifer-shehane]

• Closes Spacing of error message is too long with <br> #28452

Additional details

There was a regression introduced in 12.4.0 with this PR, where all of our error messages were formatting to include <br> tags when there was a new line in the error message.

The original PR did not run Percy checks since it was an outside contributor, so this visual change went unnoticed.

This adds an exception to the formatting logic when the message is of type: error in order to maintain the functionality of the originally intended PR to have line breaks in Cypress.log messages.

Steps to test

A test was added to cover this in the test_errors.cy.ts, we should also see Percy snapshots update.

How has the user experience changed?

Before

After

PR Tasks

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?

[brian-mann]

Can you add a test for the affirmative case where it does keep <br /> for Cypress.log(...) ? If they already exist, then just point that out.

[jennifer-shehane]

@brian-mann Yah these original tests are still there: https://github.com/cypress-io/cypress/pull/25467/files#diff-95c9055c314a4b42dab5687daf7ea43804e5ec4d3d613632153b0dbde2d33e96R56

[cypress]

4 flaky tests on run #52749 ↗︎

0

554

6

0

4

Details:

Merge branch 'develop' into fix-brs-in-error-messages
Project: cypress	Commit: 6bee50fe8f
Status: Passed	Duration: 12:57 💡
Started: Dec 12, 2023 6:39 PM	Ended: Dec 12, 2023 6:51 PM

  runs.cy.ts • 2 flaky tests • app-e2e

View Output

Test		Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params		Test Replay Screenshots
... > displays a list of recorded runs if a run has been recorded		Test Replay Screenshots

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Screenshots

  debug.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
App - Debug Page > shows running and updating build		Test Replay Screenshots

Review all test suite changes for PR #28496 ↗︎

[cypress-bot]

Released in 13.6.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.2, please open a new issue.