Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deprecate): Remove unused create-cypress-tests package #28472

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 6, 2023

Additional details

This package is no longer used or referenced in our codebase since v10 (see https://github.com/cypress-io/cypress/pull/21438/files). We are running tests within this package, which is using some resources. Cleaning up this unused package.

Screen Shot 2023-12-06 at 12 49 46 PM

Steps to test

Hopefully I didn't mis remove something in the build files. Tests should pass.

How has the user experience changed?

We will deprecate the create-cypress-tests npm package which has like ~7 dls per week, so don't see any impact.

PR Tasks

@jennifer-shehane jennifer-shehane changed the title Remove unused create-cypress-tests package feat: Remove unused create-cypress-tests package Dec 6, 2023
@jennifer-shehane jennifer-shehane changed the title feat: Remove unused create-cypress-tests package breaking: Remove unused create-cypress-tests package Dec 6, 2023
@jennifer-shehane jennifer-shehane changed the title breaking: Remove unused create-cypress-tests package feat(deprecate): Remove unused create-cypress-tests package Dec 6, 2023
.gitignore Outdated Show resolved Hide resolved
@emilyrohrbough emilyrohrbough changed the title feat(deprecate): Remove unused create-cypress-tests package chore(deprecate): Remove unused create-cypress-tests package Dec 6, 2023
@emilyrohrbough
Copy link
Member

Need to remove the required status check.
Screen Shot 2023-12-06 at 12 07 38 PM

@jennifer-shehane
Copy link
Member Author

I removed the required status checks for npm-create-cypress-tests

@MikeMcC399
Copy link
Contributor

@jennifer-shehane

How has the user experience changed?
We will deprecate the create-cypress-tests npm package which has like ~7 dls per week, so don't see any impact.

According to the npm documentation for unpublish, you could unpublish instead of deprecating, since it meets the criteria:

Packages published more than 72 hours ago

Regardless of how long ago a package was published, you can unpublish a package that meets all of the following conditions:

  • no other packages in the npm Public Registry depend on it
  • it had less than 300 downloads over the last week
  • it has a single owner/maintainer

Copy link

cypress bot commented Dec 8, 2023

@jennifer-shehane jennifer-shehane merged commit 690801a into develop Dec 11, 2023
5 checks passed
@jennifer-shehane jennifer-shehane deleted the remove-create-cy-tests branch December 11, 2023 22:23
This was referenced Dec 12, 2023
@MikeMcC399
Copy link
Contributor

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 26, 2023

Released in 13.6.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive create-cypress-tests as it's not compatible with Cypress > 9.x
4 participants