fix: do not ignore node_modules if it is specified by an user #23616

[qwazimoda]

The suggested change is to not ignore node_modules if the project's folder contains it or node_modules is specified in the path to spec files.

• Relates Support file can't be loaded if its path contains "node_modules" #24685
• Closes Specifying supportFile in config doesn't work with node_modules in path #23616

Additional details

If a project path (cwd) or a spec path (glob) contains node_modules it will not be included in the ignoring paths (ignoreGlob).

Steps to test

The related issues contain steps to reproduce. But I haven't built the fixed version locally to verify the changed behavior.

How has the user experience changed?

A few extra code checks are added. For most users, it shouldn't be detectable. The blocked users get the ability to run Cypress from the node_modules folder like they were able to do before Cypress 10.
Some future users could potentially experience some slowness (?) or see unexpected specs from Cypress if they improperly configure their environment.

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[cchaglund]

Eagerly awaiting this fix!

[cacieprins]

Thank you for submitting this! Other than some flake in the CI, it looks like it's passing. Just left one comment about expanding the test coverage.

[jordanpowell88]

LGTM! Thanks for the PR @qwazimoda! We will need to wait to merge as this will go in our next release (13.6.3 or 13.7.0)

[qwazimoda]

LGTM! Thanks for the PR @qwazimoda! We will need to wait to merge as this will go in our next release (13.6.3 or 13.7.0)

Thanks for the review.
I haven't worked with GitHub before, and I would appreciate it if you could clarify a few moments.
After the current release ('13.6.2'), if/when it happens, there will be a merge conflict in the changelog file. Would the conflict resolution reset approvals?
Do I need to track the progress with the current release to update this PR, or would someone from the maintainers take care of it since it has two approvals?

[jennifer-shehane]

@qwazimoda Fixed the changelog for you

[qwazimoda]

@qwazimoda Fixed the changelog for you

Thank you a lot!

[cypress-bot]

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.