Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue with using privileged commands when baseUrl includes basic auth credentials #28428

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Nov 29, 2023

Additional details

The fetch request to /add-verified-command failed when basic auth credentials were included in the baseUrl, causing privileged commands to not be recognized as verified. Fully qualifying the URL for the fetch fixes the issue.

Steps to test

Use this reproduction or TL:DC (too long, didn't clone):

  • Set baseUrl: https://basicuser:[email protected]/ in cypress config
  • Run a privileged command like cy.readFile("cypress/fixtures/example.json") in your spec

PR Tasks

Copy link

cypress bot commented Nov 29, 2023

8 flaky tests on run #52627 ↗︎

0 554 6 0 Flakiness 8

Details:

Merge branch 'develop' into issue-28336-privileged-command-basic-auth
Project: cypress Commit: 7654e1054c
Status: Passed Duration: 13:03 💡
Started: Nov 30, 2023 3:26 AM Ended: Nov 30, 2023 3:39 AM
Flakiness  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Screenshots
Flakiness  runs.cy.ts • 4 flaky tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Test Replay Screenshots
App: Runs > Runs - Cannot Find Project > opens Connect Project modal after clicking Reconnect Project button Test Replay Screenshots
... > displays a list of recorded runs if a run has been recorded Test Replay Screenshots
... > displays each run with correct information Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  debug.cy.ts • 2 flaky tests • app-e2e

View Output

Test Artifacts
App - Debug Page > shows information about a failed spec Test Replay Screenshots
App - Debug Page > shows running and updating build Test Replay Screenshots

Review all test suite changes for PR #28428 ↗︎

@chrisbreiding chrisbreiding merged commit 257861b into develop Nov 30, 2023
5 checks passed
@chrisbreiding chrisbreiding deleted the issue-28336-privileged-command-basic-auth branch November 30, 2023 03:40
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 5, 2023

Released in 13.6.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants