chore: Fix puppeteer plugin publishing #28408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 flaky tests on run #52500 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
| |||||||||||||||||||
| Test | Artifacts | |||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > correctly returns currentRetry |
| |||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > saves the filter when navigating to a spec and back |
Test Replay
Screenshots
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
The first 5 flaky specs are shown, see all 23 specs in Cypress Cloud.
Review all test suite changes for PR #28408 ↗︎
jennifer-shehane
approved these changes
Nov 27, 2023
…cypress into crb/cy-puppeteer-publish-fix
mschile
reviewed
Nov 27, 2023
npm/puppeteer/package.json
Outdated
| }, | ||
| "homepage": "https://github.com/cypress-io/cypress/blob/develop/npm/puppeteer/#readme", | ||
| "author": "Cypress App Team", | ||
| "bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fangular&template=1-bug-report.md&title=", |
There was a problem hiding this comment.
The label is for npm: @cypress/angular, do we have one for this plugin?
Suggested change
| "bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fangular&template=1-bug-report.md&title=", | |
| "bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fpuppeteer&template=1-bug-report.md&title=", |
There was a problem hiding this comment.
Bad copy-pasta on my part 🤦♂️ Fixed in e64b34c and created a matching label
mschile
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Scoped npm packages need
--access publicspecified for their initial release. Adding thepublishConfigtopackage.jsonfixes that for semantic-release.Also added some missing package.json fields.
Also removed the 1.0.0 changelog since it wasn't successfully published yet.
PR Tasks
cypress-documentation?type definitions?