Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add yarn pnp support for reporters (#18922) #28404

Closed
wants to merge 1 commit into from

Conversation

ernestostifano
Copy link

Additional details

As better explained here: #18922 (comment), since the loading of external reporters occur in a separate process from the one loading the Cypress configuration, Node is not able to locate/load external packages when Yarn PnP is enabled.

This PR should register Yarn PnP API before the resolvers are requested and should fix the issue.

Steps to test

TODO.

How has the user experience changed?

TODO.

PR Tasks

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cypress-app-bot
Copy link
Collaborator

@ernestostifano
Copy link
Author

I have not been able to test if this works because in order to run Cypress from its repository I need to have corepack disabled and if corepack is disabled, the target project (that uses Yarn PnP) does not work: it cannot even find Cypress to load the configuration.

I tried to run Cypress from its repository while having corepack enabled, but I got the following error:

Internal Error: Duplicate workspace name cypress: /repositories/cypress/cli conflicts with /repositories/cypress

So, I am stuck.

@jennifer-shehane
Copy link
Member

Closing for now. We don't have time to dedicate to getting this through at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress and cypress-multi-reporters Yarn 2 PNP support
4 participants