-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: also use agent on first preflight request #28340
Conversation
|
08a8529
to
838666d
Compare
838666d
to
4396b1c
Compare
This is extremely limiting us, as we run Cypress for a lot of projects and all of them now have 1 minute additional time for each project and I did not find a way to decrease the |
@Roemer Thanks for opening a PR. We'll need a test to confirm the behavior before merging and we'll take a look to review. |
This PR has not had any activity in 180 days. If no activity is detected in the next 14 days, this PR will be closed. |
This PR is still relevant. |
@Roemer Oh boy, this definitely got lost. Sorry. We'll need a test to verify this behavior in order to accept the PR. Could you write a test to verify and prevent regressions? |
Pity the PR is closed as the bug still persists. As mentioned already, it is pretty much impossible to create a test as this is dependent on a specific (corporate) network setup. Having a networking-aware developer look at it should make it fairly obvious that it is currently a bug. |
Closes #28423
We use a proxy in order to communicate with the "outside world". Now the preflight first tries a request to
api-proxy.cypress.io
but with theagent
explicitly set tonull
. When this request fails, it retries withapi.cypress.io
and this time with theagent
set.I suspect that the
agent
has the proxy info and therefore, the first request does not use the proxy and depending on the local setup, might wait up to 1 minute before aborting and retrying with the proxy. This leads to +1 minute to every cypress run.