fix: incorrect typing of "dom.getContainsSelector"

[mistic100]

This function has an "options" parameter which is not declared int the typings file.

Additional details

Additonally I think there is a problem in the implementation

On this line the parameter "matchCase" has an effective default value of true

cypress/packages/driver/src/dom/elements/find.ts

Line 305 in ab60af8

if (_.isRegExp(text) && options.matchCase === false && !text.flags.includes('i')) {

However on this line the effective default value is false

cypress/packages/driver/src/dom/elements/find.ts

Line 316 in ab60af8

let expr = _.isRegExp(text) ? 'cy-contains-regex' : (options.matchCase ? 'cy-contains' : 'cy-contains-insensitive')

This is not the goal of this PR to fix this, I don't even know how it should be fixed because it could be a breaking change.

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[mistic100]

Thanks for the added tests

[cypress]

4 flaky tests on run #53864 ↗︎

0

5508

73

0

4

Details:

Merge branch 'develop' into patch-1
Project: cypress	Commit: 6a9969cfb4
Status: Passed	Duration: 16:56 💡
Started: Feb 5, 2024 4:48 PM	Ended: Feb 5, 2024 5:05 PM

  e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test		Artifacts
cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry		Test Replay

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output

Test		Artifacts
... > correctly returns currentRetry		Test Replay
... > correctly returns currentRetry		Test Replay
... > correctly returns currentRetry		Test Replay

Review all test suite changes for PR #28339 ↗︎

[mschile]

@mistic100, thanks for the contribution and sorry for the delay in getting it merged!

[cypress-bot]

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.