fix: Cypress interprets underscores in URL as formatting instructions on frontend #28245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -38,7 +38,8 @@ export const formattedMessage = (message: string) => { | |||
| const matchingText = searchText.find((text) => message.includes(text)) | |||
| const textToConvert = [split[0].trim(), ...(matchingText ? [matchingText] : [])].join(' ') | |||
| const spaceEscapedText = textToConvert.replace(/^ +/gm, (initialSpaces) => ' '.repeat(initialSpaces.length)) //   is the HTML entity for a space | |||
| const converted = md.renderInline(spaceEscapedText) | |||
| const underscorePreservedText = spaceEscapedText.replace(/_+/gm, (initialUnderscores) => '_'.repeat(initialUnderscores.length)) //   HTML entity for underscore | |||
| const converted = md.renderInline(underscorePreservedText) | |||
There was a problem hiding this comment.
can we add a test for this?
There was a problem hiding this comment.
I updated one of the existing tests and added a clarifying comment
There was a problem hiding this comment.
@emilyrohrbough could you check out my PR #27934? I feel like it is ready to be merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The app should display urls in raw form instead of markdown to avoid being misleading.
Steps to test
How has the user experience changed?
The app shows "visit __bankTransfers__" instead of "visit: bankTransfers" when trying to visit
__bankTransfers__.Before
After
PR Tasks
cypress-documentation?type definitions?