chore: add @packages/example as a dependency of create-cypress-tests #27978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkasper-was-taken
approved these changes
Oct 4, 2023
chrisbreiding
approved these changes
Oct 5, 2023
4 flaky tests on run #51467 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| user agent override > persists modified user agent after cy.go |
Test Replay
Output
|
|
Review all test suite changes for PR #27978 ↗︎
dkasper-was-taken
deleted the
astone123/create-cypress-tests-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build step for
create-cypress-testsrelies on build output frompackages/example. This is an implicit dependency since create-cypress-tests doesn't import anything frompackages/examplein its source.This PR tells Nx that create-cypress-tests depends on
packages/example.Example CI failure