Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for versions greater than 4 for eslint-plugin-mocha to pre… #27944

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

AtofStryker
Copy link
Contributor

…vent force installing dependencies when eslint-plugin-mocha is bumbed in comsumer packages

  • Closes N/A

Additional details

Fixes incorrect peerDependency on eslint-plugin-mocha as users can use a version greater than v4.

Steps to test

How has the user experience changed?

PR Tasks

…vent force installing dependencies when eslint-plugin-mocha is bumbed in comsumer packages
@cypress
Copy link

cypress bot commented Sep 29, 2023

24 flaky tests on run #51364 ↗︎

0 28134 1345 0 Flakiness 24

Details:

Merge branch 'develop' into chore/fix_eslint-plugin-mocha-peer-dep
Project: cypress Commit: 523d5e338a
Status: Passed Duration: 18:26 💡
Started: Sep 29, 2023 7:15 PM Ended: Sep 29, 2023 7:33 PM
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output Video

Test Artifacts
... > can skip setup CT testing for an E2E project Test Replay Output Screenshots
... > can reconfigure config after CT has been set up Test Replay Output Screenshots
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

Review all test suite changes for PR #27944 ↗︎

@jennifer-shehane jennifer-shehane self-requested a review November 14, 2023 15:47
@AtofStryker AtofStryker merged commit bf05978 into develop Jan 5, 2024
77 of 82 checks passed
@AtofStryker AtofStryker deleted the chore/fix_eslint-plugin-mocha-peer-dep branch January 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants