Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use fixture as request body shortcut #27934
feat: Use fixture as request body shortcut #27934
Changes from all commits
d7d0333
a3e305e
669235c
4b6796c
dae4e2b
6aed8e7
6e94372
c9c8a0b
addfd1e
19643ec
e1c462d
81f3900
b5ff263
744f040
75d4801
aab5a97
07ac874
c8e22aa
5b12c01
3900900
b972a61
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original suggestion was a bit naive with the amount of messaging we are doing in the
cy.request()
command with assigning headers, validating the body structure etc. Your original approach was definitely better than this suggestion.What you have here makes assumptions that the fixture data that's for a form, where someone may want it for any body type.
Using the
cy.fixture()
command will cache the fixture data for the duration fo the spec, which we won't want to introduce, but we can call into the backend directly. something like?I was really hoping to avoid an extra client-side->backend-> exchange with the introduction of this feature.
@chrisbreiding maybe you have some ideas on keeping this a single exchange? maybe its not necessary?