refactor: use cypress design button in launchpad #27795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevatebart
changed the title
Passing run #53629 ↗︎
Details:
Review all test suite changes for PR #27795 ↗︎ |
|||||||||||||||
added 8 commits
November 6, 2023 15:35
| @@ -154,7 +153,7 @@ | |||
|
|
|||
| <script lang="ts" setup> | |||
| import { useI18n } from '@cy/i18n' | |||
| import Button from '@packages/frontend-shared/src/components/Button.vue' | |||
There was a problem hiding this comment.
Is this button still used or can we delete this code? '@packages/frontend-shared/src/components/Button.vue'
There was a problem hiding this comment.
To keep the PR of a decent size, I only worked on the LaunchPad for now.
In a 2nd PR, I will process the app and delete the unused Button.
Co-authored-by: Emily Rohrbough <[email protected]>
emilyrohrbough
approved these changes
Jan 8, 2024
added 10 commits
January 8, 2024 18:08
This reverts commit 9ffbcf2.
ryanjwilke
approved these changes
Jan 10, 2024
|
|
added 8 commits
January 16, 2024 18:00
elevatebart
deleted the
refactor/use-cypress-design-button-in-launchpad
branch
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cypress-io/cypress-design#189
Assumptions
pendingis alwaysdisabledso the variants are mergedsmis 24 px tall, set the size accordinglylgis 40 px tall, set the size accordinglylight-indigouseExternalLink()hook directly when necessary.