fix: fix third party reporters and cy.origin calls in Cypress #24614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
…at-binary-rather-than-monorepo
| @@ -249,7 +249,7 @@ const preprocessor: WebpackPreprocessor = (options: PreprocessorOptions = {}): F | |||
| webpackOptions.module.rules.unshift({ | |||
| test: /\.(js|ts|jsx|tsx)$/, | |||
| use: [{ | |||
| loader: path.join(__dirname, 'lib/cross-origin-callback-loader'), | |||
| loader: require.resolve('@cypress/webpack-preprocessor/dist/lib/cross-origin-callback-loader.js'), | |||
There was a problem hiding this comment.
If we need to do require.resolve() within the NPM module, is there risk that custom webpack configuration will be problematic or is this only for snapshot resolution in the binary?
There was a problem hiding this comment.
This is only for snapshot resolution in the binary.
There was a problem hiding this comment.
& vite doesn't have issues because we don't ship with the binary? https://github.com/cypress-io/cypress/blob/develop/npm/vite-dev-server/src/resolveConfig.ts#L14
| @@ -20,6 +20,7 @@ | |||
| "watch": "rimraf dist && tsc --watch" | |||
| }, | |||
| "dependencies": { | |||
| "@babel/parser": "7.13.0", | |||
There was a problem hiding this comment.
why does this need @babel/parser?
mjhenkes
approved these changes
Nov 9, 2022
emilyrohrbough
approved these changes
Nov 9, 2022
…at-binary-rather-than-monorepo
ryanthemanuel
deleted the
ryanm/fix/improve-binary-cleanup-to-look-at-binary-rather-than-monorepo
branch
ryanthemanuel
restored the
ryanm/fix/improve-binary-cleanup-to-look-at-binary-rather-than-monorepo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress run->Error: Cannot find module 'mocha-7.0.1'#24607v11.0.0Broken withexperimentalSessionAndOrigin: true#24611User facing changelog
Cypress will no longer crash when using a third party reporter like
mochawesome.Cypress will no longer crash when using the
experimentalSessionAndOriginflag.Additional details
When cleaning up the binary due to the v8 snapshot work, there were a couple of dependencies that were removed that shouldn't have been.
In the case of third party mocha reporters, we do some swizzling at runtime with a hard coded version of mocha (mocha-7.0.1). In order to allow this to work properly, we need to leave
mocha-7.0.1in the binary.In the case of the
experimentalSessionAndOriginflag, we have a dynamically loaded loader whose dependencies were not being flagged as something that shouldn't be removed. We will ensure that these dependencies are kept by wrapping this dependency in arequire.resolve.Steps to test
Run the binary with a third party reporter like
mochaawesomeRun the binary with
experimentalSessionAndOriginturned onHow has the user experience changed?
The app no longer crashes in the above scenarios.
PR Tasks
cypress-documentation?type definitions?