Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optionally highlighted element's shadow root #21008

Conversation

simenbrekken-visma
Copy link

@simenbrekken-visma simenbrekken-visma commented Apr 9, 2022

User facing changelog

  • When using the selector playground to locate elements, optionally search within the found element's shadow root

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 9, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@simenbrekken-visma simenbrekken-visma changed the title Optionally highlighted element's shadow root fix: Optionally highlighted element's shadow root Apr 9, 2022
@simenbrekken-visma simenbrekken-visma force-pushed the selector-playground-shadow-dom branch from 0f5836b to 9d1d215 Compare April 9, 2022 05:37
@jennifer-shehane
Copy link
Member

@simenbrekken Make sure to sign our CLA when you get a chance. You still have some more code to add for this PR?

@simenbrekken-visma
Copy link
Author

@jennifer-shehane I haven't been able to get unique-selector working with this patch and I'm not familiar with how this actually works either, so any help finishing this up would be greatly appreciated.

I'll sign the CLA as soon as I get a thumbs up from my employer

@simenbrekken-visma
Copy link
Author

@jennifer-shehane I'm getting a 401 on the CLA signing page, any ideas?

@jennifer-shehane
Copy link
Member

@simenbrekken Can you try again?

@nagash77
Copy link
Contributor

Hi @simenbrekken-visma do you plan on picking this work back up or should this draft PR be closed?

@simenbrekken-visma
Copy link
Author

I didn't get any further as https://github.com/ericclemmons/unique-selector needs to be updated AFAIK and it appears to have been abandoned. You can probably close it.

@nagash77 nagash77 closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selector playground does not support Shadow DOM
5 participants