fix: e2e percy snapshots #20604
fix: e2e percy snapshots #20604
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…ove from gulp build processes
- this is already handled and defined in the router above
This reverts commit 543a590.
- /__launchpad -> /__cypress/launchpad - /__socket -> /__cypress/socket.io - /__app-socket -> /__cypress-app/socket.io - socketIoCookie: __socket -> __socketIo
There was a problem hiding this comment.
Seems fine - good solution. For anyone else looking at this PR - there's a ton of renames here, the main change is in this file: https://github.com/cypress-io/cypress/pull/20604/files#diff-040b9d41ce1efd9534f52c69af25d3d587c3a5b9cc9cb8b39a2848ec3e7e420e.
I also pulled the branch locally and tested a bit, everything seems 💯 . We had better approve the remaining 18 snapshots on Percy before merging (since they are now showing correctly).
| @@ -48,15 +48,39 @@ const _forceProxyMiddleware = function (clientRoute, namespace = '__cypress') { | |||
| `/${namespace}/runner/cypress_runner.css`, | |||
| `/${namespace}/runner/cypress_runner.js`, // TODO: fix this | |||
| `/${namespace}/runner/favicon.ico`, | |||
|
|
|||
| @@ -1,10 +1,9 @@ | |||
| import { makeConfig } from '../frontend-shared/vite.config' | |||
| import Layouts from 'vite-plugin-vue-layouts' | |||
| import Pages from 'vite-plugin-pages' | |||
| import Copy from 'rollup-plugin-copy' | |||
There was a problem hiding this comment.
Thank you for that !!
Great clean-up.
Should we also remove the plugin from the dependencies in package.json?
There was a problem hiding this comment.
Makes sense, I went ahead and removed it.
|
@brian-mann Is this PR ready for review? I know you are working on cleaning up some of the snapshots, but I'm not sure if you are wanting to merge those changes here or in a follow-up PR. |
Co-authored-by: Ryan Manuel <[email protected]>
lmiller1990
dismissed stale reviews from ryanthemanuel and themself
via
061d9ed
|
I went ahead and merged in 10.0-release, resolved conflicts, and made the trivial review changes (typos, remove unused dep from @tbiethman it's marked as ready and in review - I'd assume we are good to review/merge. It seems like a good place to merge - CI is green. |
|
I confirmed with @brian-mann - he said this should still be in draft, he has some things to finalize. @lmiller1990 if you'd like you can sync with Brian to see what he wanted done and see if you can take over the tasks. Otherwise it's not ready for review. |
There was a problem hiding this comment.
@brian-mann Update the base branch to be against develop before merging.
|
Closing as stale. We can re-visit at a later time. |
Details
Allows static vue assets to be accessible without going through the proxy.
Percy generates local snapshots outside of Cypress in their own browser without configuring the proxy server. Our internal proxy server normally rejects requests made outside of the browser (in the proxy mode). This change allows static assets for vite to be served.