Cacie/chore/upgrade electron 27 #28544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a given electron version
Co-authored-by: Cacie Prins <[email protected]>
cli/CHANGELOG.md
Outdated
| - Updated `@cypress/unique-selector` to include a performance optimization. It's possible this could improve performance of the selector playground. Addressed in [#28571](https://github.com/cypress-io/cypress/pull/28571). | ||
| - Upgraded `electron` from `25.8.4` to `27.1.3` | ||
| - Upgraded bundled Node.js version from `18.15.0` to `18.17.0` | ||
| - Upgraded bundled Chromium version from `114.0.5735.289` to `116.0.5845.228` |
There was a problem hiding this comment.
Chromium version is v18.17 -- https://www.electronjs.org/docs/latest/tutorial/electron-timelines / showing in System Tests output as well
| @@ -211,7 +212,7 @@ | |||
| "yarn-deduplicate": "3.1.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">=18.15.0", | |||
| "node": ">=18.17.0", | |||
There was a problem hiding this comment.
This would be non-passive to bump for yarn projects
There was a problem hiding this comment.
wait -- my bad -- this is our for our development version. This is fine. I mistook this for cli/package.json.
Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com>
* chore(deps): update dependency vite [security] * empty commit to trigger CI --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <[email protected]>
… from a support file (#28748) * fix: issue with service workers in test replay when they're initiated from a support file * add changelog * Update cli/CHANGELOG.md Co-authored-by: Bill Glesias <[email protected]> * PR comment * get prerelease * PR comments * Update .circleci/workflows.yml * Update .circleci/workflows.yml Co-authored-by: Matt Schile <[email protected]> --------- Co-authored-by: Bill Glesias <[email protected]> Co-authored-by: Matt Schile <[email protected]>
* chore: update octokit packages to latest. removals/deprecations do not impact us and most breaking changes are dropped support for Node <18 * test binary comment task [run ci] * chore: update arm64 image is it is deprecated * run ci
|
Closing this PR due to botched merge/rebase- PR that continues the process at #28792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?